feat(java 21): allow toplevel method declarations #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR allows top-level statements to comprise of method declarations.
Why:
This is because Java 21 adds "unnamed classes", which means such classes can now be "anonymous", and now method declarations can just exist at the top level. This is a Java 21 feature that the grammar should aim to accommodate.
How:
Just made a new hidden nonterminal called
toplevel_statements
, which may be amethod_declaration
.I could have changed
statement
itself, butstatement
is used at places that are not the top level, and this causes conflicts.Worth noting that the state count increases by about 100. That's not a whole lot, so I'm cool with it, but worth noting.
Test plan:
tree-sitter test
Checklist: