-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(java 21): complete pattern matching for switch statements #158
feat(java 21): complete pattern matching for switch statements #158
Conversation
need to rebase |
3b8f6e6
to
0d0b834
Compare
@aryx rebased now |
Can you remove the regenerated files? Then it'd be nice to merge your 3 PRs and then generate after that |
0d0b834
to
4cfbaed
Compare
@amaanq done! |
@amaanq well, this will also fail CI in the interim, unfortunately... |
@amaanq it seems it's not possible to do "partial commits" with the regeneration step at a later time, because CI must pass before i merge. i think i'm just going to merge individually. |
okay, that's fine. you can add back the generated files. |
@aryx could you merge this? |
What:
This PR adds in the last thing for supporting pattern matching for
switch
statements, as in Java 21, namely guards.Why:
We should support the features of Java 21.
How:
Just added a
guard
nonterminal and put it in the right place, and added more tests for other Java 21switch
features.Test plan:
tree-sitter test
Checklist: