Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent mangled URL in .pc file #155

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

mavit
Copy link
Contributor

@mavit mavit commented Aug 2, 2023

Previously, the Makefile assumed that Git URLs were always “SSH style”, e.g., [email protected]:tree-sitter/tree-sitter-java.git. This change causes the right thing to be done when a normal URL is encountered, e.g. https://github.com/tree-sitter/tree-sitter-java.git.

Relates to https://bugzilla.redhat.com/show_bug.cgi?id=2193261

Checklist:

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature. There do not appear to be any existing tests for this.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

Previously, the `Makefile` assumed that Git URLs were always “SSH style”, e.g., `[email protected]:tree-sitter/tree-sitter-java.git`.  This change causes the right thing to be done when a normal URL is encountered, e.g. `https://github.com/tree-sitter/tree-sitter-java.git`.

Relates to https://bugzilla.redhat.com/show_bug.cgi?id=2193261
@amaanq
Copy link
Member

amaanq commented Aug 2, 2023

makes sense, thanks!

@amaanq amaanq merged commit e8d1bc4 into tree-sitter:master Aug 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants