Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some grammar fixes for Java 21 #153

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Some grammar fixes for Java 21 #153

merged 5 commits into from
Aug 16, 2023

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Jul 26, 2023

I added patterns as Java 21 comes out in September

See https://openjdk.org/projects/jdk/21/

Closes #150
Closes #151
Closes #152

@amaanq amaanq requested a review from aryx July 26, 2023 13:11
test/corpus/expressions.txt Outdated Show resolved Hide resolved
@amaanq amaanq requested a review from aryx July 26, 2023 14:32
Copy link
Contributor

@aryx aryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still

grammar.js Show resolved Hide resolved
test/corpus/declarations.txt Outdated Show resolved Hide resolved
test/corpus/declarations.txt Outdated Show resolved Hide resolved
test/corpus/expressions.txt Show resolved Hide resolved
test/corpus/expressions.txt Show resolved Hide resolved
grammar.js Show resolved Hide resolved
'record',
'with',
'yield',
'sealed',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need non-sealed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's valid, if it is lmk

@amaanq amaanq merged commit 8d012be into tree-sitter:master Aug 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when variable name is yield Error when method name is module Error when variable name is sealed
3 participants