Make predicate with missing capture return true #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaanq
force-pushed
the
predicate-optional-capture
branch
from
f5f2dfa
to
a022d9e
Compare
|
Makes sense, thanks for the fix! Sorry for the delay in review :) |
amaanq
approved these changes
Nov 12, 2023
|
ASAN isn't happy |
If a predicate in a query references a capture that was not matched because it was optional in the query, return true rather than throw an error. In other words, if the capture was not found, ignore the predicate entirely. This matches the behavior of tree-sitter CLI and the playground. It is not a common case but we have run into the issue matching Kotlin functions where the return type of a function is optional in the grammar requiring us to do additional filtering in the app code after the query.
amaanq
force-pushed
the
predicate-optional-capture
branch
from
a022d9e
to
2ee6960
Compare
amaanq
approved these changes
Nov 12, 2023
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a predicate in a query references a capture that was not matched because it was optional in the query, return true rather than throw an error. In other words, if the capture was not found, ignore the predicate entirely.
This matches the behavior of tree-sitter CLI and the playground. It is not a common case but we have run into the issue matching Kotlin functions where the return type of a function is optional in the grammar requiring us to do additional filtering in the app code after the query.