Resolve --keep-translations argument issue #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates Transifex SDK package to v2.0.1
The `--keep-translations` argument of the `push` command was a boolean flag that had a default value of `true`. This meant that if user did not supply the `--keep-translations` argument to their `push` command the value would be `true` and if they did, the value would also be `true`, making it impossible for the `--keep-translations` flag to be false. In order to fix the issue, the argument has been replaced with the inverse flag: `--delete-translations`. Its default value is `false` so it behaves exactly as the `--keep-translations` before, if the argument was not supplied (`keep_translations` is going to be set to `true`). The difference is that now if this new argument is supplied, then the underlying value of the `keep_translations` metadata will be `false`.
* Bumps CLI version to 2.1.4. * Updates the CHANGELOG.
stelabouras
changed the title
n1k0sv
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Transifex SDK package to v2.0.1
Resolve --keep-translations argument issue
The
--keep-translationsargument of thepushcommand was a booleanflag that had a default value of
true. This meant that if user didnot supply the
--keep-translationsargument to theirpushcommandthe value would be
trueand if they did, the value would also betrue, making it impossible for the--keep-translationsflag to befalse.
In order to fix the issue, the argument has been replaced with the
inverse flag:
--delete-translations. Its default value isfalsesoit behaves exactly as the
--keep-translationsbefore, if the argumentwas not supplied (
keep_translationsis going to be set totrue).The difference is that now if this new argument is supplied, then the
underlying value of the
keep_translationsmetadata will befalse.Bump version to 2.1.4