Base SDK option in push command #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When exporting localizations via the `push` command, the default SDK that was being used was the `macosx` one, resulting to errors when the project included Swift packages using iOS frameworks. In order to address this and provide more control to the developer, a new option was introduced in the `push` command: `--base-sdk`. The value of this option is passed as the `-sdk` option of the `xcodebuild` process that is called to export the project's localizations (via the `-exportLocalizations` option). If no value is provided to this option, then the value of the `-sdk` option is also not specified in the `xcodebuild` process and the default SDK is picked by the system.
* Bumps CLI version to 2.1.3. * Updates the CHANGELOG.
stelabouras
force-pushed
the
feature/base-sdk
branch
from
5d4968a
to
7ad9f40
Compare
n1k0sv
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add base SDK option for push command
When exporting localizations via the
pushcommand, the default SDKthat was being used was the
macosxone, resulting to errors whenthe project included Swift packages using iOS frameworks.
In order to address this and provide more control to the developer, a
new option was introduced in the
pushcommand:--base-sdk.The value of this option is passed as the
-sdkoption of thexcodebuildprocess that is called to export the project'slocalizations (via the
-exportLocalizationsoption).If no value is provided to this option, then the value of the
-sdkoption is also not specified in the
xcodebuildprocess and the defaultSDK is picked by the system.
Bump version to 2.1.3