Version 2.1.1 #28
Merged
Version 2.1.1 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pull logic used to always default to the 'en' source locale, so projects with a different source locale would fail to fetch the source locale strings. This commit introduces the `--source-locale` option that can be used to fetch the correct locale from Transifex.
The logic responsible for excluding the filename list provided by the developer via the respective option of the push command was not including the `UNSUPPORTED_FILES`, thus not excluding files that are not supported by the SDK like `InfoPlist.strings` or `Root.string`. This commit fixes this issue by passing the correct array to the logic.
iOS accesses the language tags using a hyphen (e.g. `en-GB`), whilst Transifex uses an underscore for the delimiter (e.g. `en_GB`). This discrepancy can cause confusion to developers which expect the Transifex format and will try to pass that in the `--source-locale` option of the `push` command, causing the push logic to fail to export the localizations from the project. This commit addresses the issue by normalizing the `sourceLocale` argument in the `LocalizationExporter` constructor so that the underscore character (`_`) is replaced with a hypen (`-`) so that the `xcodebuild` command will be able to export the localizations correctly.
* Bumps CLI version to 2.1.1. * Updates the CHANGELOG.
n1k0sv
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a number of fixes that are outlined in each separate commit and in the CHANGELOG.
More specifically:
--source-localeoption topullcommand so that developers can specifythe source locale, if it's different than
en. If not provided, thepulllogic default to the
ensource locale.pushcommand where the unsupported SDK files were notbeing excluded by the localization parsing logic.
pushcommand, the--source-localeoption refers to the source locale of the Xcode project andthe format used by Xcode and iOS is different than the format used by Transifex
(e.g
en-USinstead ofen_US). For that reason the source locale string isnow normalized before being passed to the exporter logic so that the latter can
always be able to export the source locale from the Xcode project.