Update React hooks to pass custom tx instance #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1k0sv
force-pushed
the
react-hooks-tx-instance
branch
from
2f7716b
to
32b7dd9
Compare
unkillbob
reviewed
Jan 4, 2024
| } | ||
|
|
||
| function translateWithElements(_str, props, tx) { | ||
| const _t = tx.t || t; |
There was a problem hiding this comment.
Is tx always defined here? Might want to null check it to be safe
n1k0sv
force-pushed
the
react-hooks-tx-instance
branch
from
32b7dd9
to
efe4322
Compare
kbairak
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: #182