Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log not found languages files instead of raising a KeyError #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mart-e
Copy link
Contributor

@mart-e mart-e commented May 19, 2015

If for a resource, a translation file is not present, it should be logged but
not interrupt the upload (or at least not with a traceback)

How to reproduce

  • create a project with two resources
  • add french translation file in the second resource one but not in the first
  • execute tx push -t -l fr --skip

Expected

  • translation of the second resource pushed to server

Actual

  • KeyError and the program exits

In my workflow, we add translation files only once at least one word is translated so new resources will not contains any translation files at first.

If for a resource, a translation file is not present, it should be logged but
not interrupt the upload (or at least not with a traceback)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant