Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log level of remote lang to local path message #251

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

Diontsoumas
Copy link
Contributor

@Diontsoumas Diontsoumas commented Nov 29, 2018

PR #238 fixes an issue we had for ages, where an INFO message was treated as a WARNING, showing a warning message on every tx pull. The issue was introduced back in 2012 (d8add0c), probably due to copying and pasting.

The original PR was missing the ENV variables added by the CircleCI (because the user opened the PR from a forked repo) so the tests were failing.

Message from the original PR:
Fixes #237.

Copy link
Contributor

@dbendilas dbendilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tx pull issues "WARNING: -> fr: fr.po" but no details on what it's actually warning about
3 participants