Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BOM (Byte Order Mark) bytes #356

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Remove BOM (Byte Order Mark) bytes #356

merged 1 commit into from
Nov 4, 2024

Conversation

arisktfx
Copy link
Contributor

@arisktfx arisktfx commented Oct 23, 2024

Problem and/or solution

When the docx file contains BOM (Byte Order Mark) bytes the parser cannot get the content. This fix removes the BOM bytes from the beginning of the file, if they exists.

Reviewer checklist

Code:

  • Change is covered by unit-tests
  • Code is well documented, well styled and is following best practices
  • Performance issues have been taken under consideration
  • Errors and other edge-cases are handled properly

PR:

  • Problem and/or solution are well-explained
  • Commits have been squashed so that each one has a clear purpose
  • Commits have a proper commit message according to TEM

@arisktfx arisktfx force-pushed the parse_file_with_bom branch 2 times, most recently from b30aa18 to 1deccc9 Compare October 29, 2024 07:48
@arisktfx arisktfx changed the title Read and write file in binary mode to remove BOM (Byte Order Mark) bytes Read file in binary mode to remove BOM (Byte Order Mark) bytes Oct 29, 2024
@arisktfx arisktfx force-pushed the parse_file_with_bom branch 2 times, most recently from d36491d to bd92e21 Compare October 29, 2024 13:08
@arisktfx arisktfx changed the title Read file in binary mode to remove BOM (Byte Order Mark) bytes Remove BOM (Byte Order Mark) bytes Oct 29, 2024
@arisktfx arisktfx merged commit 9b4fdee into devel Nov 4, 2024
4 checks passed
@arisktfx arisktfx deleted the parse_file_with_bom branch November 4, 2024 12:27
@txsentinel txsentinel mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants