Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Android XML v3 escaping #326

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Fix Android XML v3 escaping #326

merged 2 commits into from
Feb 20, 2024

Conversation

arisktfx
Copy link
Contributor

@arisktfx arisktfx commented Feb 1, 2024 •
edited
Loading

Problem and/or solution

Alter Android XML v3 fromat handler to protect inline tags from escaping/ unescaping special characters.

Reviewer checklist

Code:

  • Change is covered by unit-tests
  • Code is well documented, well styled and is following best practices
  • Performance issues have been taken under consideration
  • Errors and other edge-cases are handled properly

PR:

  • Problem and/or solution are well-explained
  • Commits have been squashed so that each one has a clear purpose
  • Commits have a proper commit message according to TEM

@arisktfx arisktfx force-pushed the correctly_parse_android_xml branch 2 times, most recently from 70d3150 to 4a0719f Compare February 1, 2024 14:49
manos-transifex
manos-transifex previously approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@manos-transifex manos-transifex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@arisktfx arisktfx force-pushed the correctly_parse_android_xml branch 2 times, most recently from 834549f to 38ac98f Compare February 5, 2024 13:01
@arisktfx arisktfx force-pushed the correctly_parse_android_xml branch 3 times, most recently from dd96880 to 2b5159c Compare February 15, 2024 08:25
@arisktfx arisktfx force-pushed the correctly_parse_android_xml branch 3 times, most recently from f46bc9f to d22df4e Compare February 15, 2024 11:45
manos-transifex
manos-transifex approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@manos-transifex manos-transifex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@arisktfx arisktfx merged commit 34554ee into devel Feb 20, 2024
3 checks passed
@txsentinel txsentinel mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manos-transifex manos-transifex manos-transifex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arisktfx @manos-transifex