-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ui of page show winnner #111
base: master
Are you sure you want to change the base?
Conversation
conglt-0917
commented
Aug 28, 2019
@@ -563,7 +563,13 @@ export const getAliasBalance = () => async (dispatch, getState) => { | |||
if (aliasBalance.includes('.')) { | |||
let interger = aliasBalance.split('.', 2)[0]; | |||
let fractional = aliasBalance.split('.', 2)[1].substr(0, 4); | |||
aliasBalance = interger.concat('.', fractional, ' '); | |||
if (interger === '0' && fractional === '0000') { | |||
aliasBalance = '0 '; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dấu cách sau số 0 để làm gì vậy bạn?
@@ -83,7 +83,7 @@ class ModalDeposit extends React.Component { | |||
</ModalBody> | |||
</FormGroup> | |||
<ModalFooter> | |||
<Button color='primary' type='submit'> | |||
<Button color='primary' type='submit' onClick={this.toggle}> | |||
Send |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n
@@ -82,7 +82,13 @@ class PlayerLayout extends Component { | |||
<Row className='set_height'> | |||
<Col className='box_color' xs='12' md='8'> | |||
<div className='margin_box '> | |||
<span> The winner is youuuuu</span> | |||
<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viết style đi, tạo khoảng cách như này thô quá! Mai cần cách đoạn nữa lạ thêm
vào à?
<br /> | ||
<p className='congrat'>Congratulation! You are winner</p> | ||
<div> | ||
<strong>Game Balance:</strong> {this.props.aliasBalance} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ngộ nhỡ props bị null???
https://stackoverflow.com/questions/42232063/react-print-this-props-only-when-value-is-not-null
<p className='congrat'>Congratulation! You are winner</p> | ||
<div> | ||
<strong>Game Balance:</strong> {this.props.aliasBalance} | ||
<img width='35' src='https://i.imgur.com/VZgib3M.png' alt='tomoCoin' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K được viết inline style như này, cho vào file style khi cần sửa trong file
src cho vào config
width: 14%; | ||
} | ||
} | ||
|
||
@media only screen and (max-width: 700px) { | ||
.switchSmall { | ||
position: absolute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nên chuyển indent sang 4 spaces cho đỡ đau mắt