fix build in jruby && truffleruby #265
Conversation
seuros
force-pushed
the
testexotic
branch
2 times, most recently
from
c99d58d
to
d117199
Compare
|
|
||
| property :qualification | ||
|
|
||
| property :name, namespace: "http://eric.van-der-vlist.com/ns/person" |
There was a problem hiding this comment.
Why change this line ? Shouldn't we check both namespace as method and namespace as option ?
There was a problem hiding this comment.
Namespace already inherited from parent object.
It the same
There was a problem hiding this comment.
No, I think the namespace defined at property level overrides the parent one. For example, character.qualification remains lib where as character.name changes to hr. We should revert this change
There was a problem hiding this comment.
The namespace change need to have similar structure. we can fix this test when i will fix the jruby build.
There was a problem hiding this comment.
Ok, I think let's skip this for jruby and we'll come up with different example so it can be compatible to test overriding the namespace.
For now, let's revert this change.
| @@ -11,27 +11,27 @@ | |||
| # <hr:born>1922-11-26</hr:born> | |||
| # <hr:dead>2000-02-12</hr:dead> | |||
| # </hr:author> | |||
| # <lib:character id="PP"> | |||
| # <hr:character id="PP"> | |||
There was a problem hiding this comment.
Why change from lib to hr ?
There was a problem hiding this comment.
xmlns:lib="http://eric.van-der-vlist.com/ns/library"
xmlns:hr="http://eric.van-der-vlist.com/ns/person">
Lib is for library and HR for the person
There was a problem hiding this comment.
Yeah, but character is the property of lib and not hr
There was a problem hiding this comment.
It possible in the code, but not valid xml, that is why it was failing in jruby since the library in java don't support it.
I can skip this test in jruby
Removed all deprecation warnings.
Green in Truffleruby
2 specs failing in jruby (i will fix them later)
All green in Ruby
Updated syntax to make it work with the other engines.