Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.0.2 #117

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Release 2.0.2 #117

merged 2 commits into from
Apr 25, 2024

Commits on Apr 25, 2024

  1. Don't pass reference of batchOperation to closure to keep behavior be… 

    …fore c7c79c7
    @HeEAaD
    HeEAaD committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0002569 View commit details
    Browse the repository at this point in the history

  2. Don't pass reference of batchOperation to closure to restore behavior… 

    … before c7c79c7 (#116)

c7c79c7 introduced a regression: 
The completion closure of
`UICollectionView.performBatchUpdates(_:completion:)` has a strong
reference to `batchOperation`. This causes that the `batchOperation`
stays longer in memory as the collection view itself.

A symptom of this is that `MainCollectionViewContext.apply(update:)`
might get called while the `adapter` is deallocated already.

This PR restores behavior to the state before
c7c79c7 by just referencing the
`completion` closure instead of `batchOperation`.
    @HeEAaD
    HeEAaD authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a59e6bf View commit details
    Browse the repository at this point in the history