Don't pass reference of batchOperation to closure to restore behavior before c7c79c7 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeEAaD
changed the title
CalvinChangCC
approved these changes
Apr 25, 2024
HeEAaD
force-pushed
the
revert_c7c79c7808037ec56555e59a373f9339e634457c
branch
from
30b1307
to
8a75feb
Compare
HeEAaD
force-pushed
the
revert_c7c79c7808037ec56555e59a373f9339e634457c
branch
from
8a75feb
to
0002569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c7c79c7 introduced a regression:
The completion closure of
UICollectionView.performBatchUpdates(_:completion:)has a strong reference tobatchOperation. This causes that thebatchOperationstays longer in memory as the collection view itself.A symptom of this is that
MainCollectionViewContext.apply(update:)might get called while theadapteris deallocated already.This PR restores behavior to the state before c7c79c7 by just referencing the
completionclosure instead ofbatchOperation.