Skip to content

Commit

Permalink
pkp#10292 fixed issue the data building with settings attrs
Browse files Browse the repository at this point in the history
  • Loading branch information
touhidurabir committed Oct 23, 2024
1 parent bed3f45 commit fb50a00
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion classes/core/SettingsBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ protected function getModelWithSettings(array|string $columns = ['*']): Collecti
$exactRow = $rows->pull($settingModelId);

// Even for empty('') locale, the multilingual props need to be an array
if (isset($setting->locale)) {
if (isset($setting->locale) && $this->isMultilingual($setting->setting_name)) {
$exactRow->{$setting->setting_name}[$setting->locale] = $setting->setting_value;
} else {
$exactRow->{$setting->setting_name} = $setting->setting_value;
Expand Down

0 comments on commit fb50a00

Please sign in to comment.