fixes related to metadata backends #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // deriving address from pub key coz pubkey is always available | ||
| // but finalPrivKey won't be available for v2 user upgraded to 2/n | ||
| let finalEvmAddress = ""; | ||
| if (finalPubKey) { |
There was a problem hiding this comment.
in wht scenario finalPubKey won't be available ?
There was a problem hiding this comment.
the bug scenario where metadata doesn't come
There was a problem hiding this comment.
it should throw when metadata is missing right?
| @@ -33,8 +33,8 @@ export function generateMetadataParams(ecCurve: ec, serverTimeOffset: number, me | |||
| }; | |||
| const sig = key.sign(keccak256(Buffer.from(stringify(setData), "utf8")).slice(2)); | |||
| return { | |||
| pub_key_X: key.getPublic().getX().toString("hex", 64), | |||
| pub_key_Y: key.getPublic().getY().toString("hex", 64), | |||
| pub_key_X: key.getPublic().getX().toString("hex"), // DO NOT PAD THIS. BACKEND DOESN'T | |||
There was a problem hiding this comment.
we should update backend isn't it? Coz there might still be 0's in front which can get lost on the network.
There was a problem hiding this comment.
can't update backend due to legacy reasons.
0's don't get lost because we always transmit strings across network
himanshuchawla009
approved these changes
Aug 21, 2023
| // deriving address from pub key coz pubkey is always available | ||
| // but finalPrivKey won't be available for v2 user upgraded to 2/n | ||
| let finalEvmAddress = ""; | ||
| if (finalPubKey) { |
There was a problem hiding this comment.
it should throw when metadata is missing right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.