-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: errors are not being sent to Sentry #76
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arch1995
reviewed
Apr 2, 2024
also fix comment mismatch code
chaitanyapotti
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 23, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@toruslabs/constants](https://togithub.com/torusresearch/fetch-node-details) | [`^13.2.0` -> `^13.3.0`](https://renovatebot.com/diffs/npm/@toruslabs%2fconstants/13.2.0/13.3.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@toruslabs%2fconstants/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@toruslabs%2fconstants/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@toruslabs%2fconstants/13.2.0/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@toruslabs%2fconstants/13.2.0/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>torusresearch/fetch-node-details (@​toruslabs/constants)</summary> ### [`v13.3.0`](https://togithub.com/torusresearch/fetch-node-details/releases/tag/v13.3.0) [Compare Source](https://togithub.com/torusresearch/fetch-node-details/compare/v13.2.0...v13.3.0) #### What's Changed - fix: errors are not being sent to Sentry by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/76](https://togithub.com/torusresearch/fetch-node-details/pull/76) - Pd 3414/update deps by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/74](https://togithub.com/torusresearch/fetch-node-details/pull/74) - Pd 3414/fix sentry no errors 2 by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/78](https://togithub.com/torusresearch/fetch-node-details/pull/78) - redact sentry data by [@​chaitanyapotti](https://togithub.com/chaitanyapotti) in [https://github.com/torusresearch/fetch-node-details/pull/79](https://togithub.com/torusresearch/fetch-node-details/pull/79) - chore: update http-helpers and loglevel-sentry by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/80](https://togithub.com/torusresearch/fetch-node-details/pull/80) - feat: introduce `Trace-Id` header by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/81](https://togithub.com/torusresearch/fetch-node-details/pull/81) - Pd 3415/sentry sample rate configurable by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/82](https://togithub.com/torusresearch/fetch-node-details/pull/82) - added support for tss-frost endpoints by [@​himanshuchawla009](https://togithub.com/himanshuchawla009) in [https://github.com/torusresearch/fetch-node-details/pull/83](https://togithub.com/torusresearch/fetch-node-details/pull/83) #### New Contributors - [@​maneki-admin](https://togithub.com/maneki-admin) made their first contribution in [https://github.com/torusresearch/fetch-node-details/pull/76](https://togithub.com/torusresearch/fetch-node-details/pull/76) **Full Changelog**: torusresearch/fetch-node-details@v13.2.0...v13.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 23, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@toruslabs/constants](https://togithub.com/torusresearch/fetch-node-details) | [`^13.2.0` -> `^13.3.0`](https://renovatebot.com/diffs/npm/@toruslabs%2fconstants/13.2.0/13.3.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@toruslabs%2fconstants/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@toruslabs%2fconstants/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@toruslabs%2fconstants/13.2.0/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@toruslabs%2fconstants/13.2.0/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>torusresearch/fetch-node-details (@​toruslabs/constants)</summary> ### [`v13.3.0`](https://togithub.com/torusresearch/fetch-node-details/releases/tag/v13.3.0) [Compare Source](https://togithub.com/torusresearch/fetch-node-details/compare/v13.2.0...v13.3.0) #### What's Changed - fix: errors are not being sent to Sentry by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/76](https://togithub.com/torusresearch/fetch-node-details/pull/76) - Pd 3414/update deps by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/74](https://togithub.com/torusresearch/fetch-node-details/pull/74) - Pd 3414/fix sentry no errors 2 by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/78](https://togithub.com/torusresearch/fetch-node-details/pull/78) - redact sentry data by [@​chaitanyapotti](https://togithub.com/chaitanyapotti) in [https://github.com/torusresearch/fetch-node-details/pull/79](https://togithub.com/torusresearch/fetch-node-details/pull/79) - chore: update http-helpers and loglevel-sentry by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/80](https://togithub.com/torusresearch/fetch-node-details/pull/80) - feat: introduce `Trace-Id` header by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/81](https://togithub.com/torusresearch/fetch-node-details/pull/81) - Pd 3415/sentry sample rate configurable by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/82](https://togithub.com/torusresearch/fetch-node-details/pull/82) - added support for tss-frost endpoints by [@​himanshuchawla009](https://togithub.com/himanshuchawla009) in [https://github.com/torusresearch/fetch-node-details/pull/83](https://togithub.com/torusresearch/fetch-node-details/pull/83) #### New Contributors - [@​maneki-admin](https://togithub.com/maneki-admin) made their first contribution in [https://github.com/torusresearch/fetch-node-details/pull/76](https://togithub.com/torusresearch/fetch-node-details/pull/76) **Full Changelog**: torusresearch/fetch-node-details@v13.2.0...v13.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 23, 2024
…#5305) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@toruslabs/fetch-node-details](https://togithub.com/torusresearch/fetch-node-details-sapphire#readme) ([source](https://togithub.com/torusresearch/fetch-node-details)) | [`^13.2.0` -> `^13.3.0`](https://renovatebot.com/diffs/npm/@toruslabs%2ffetch-node-details/13.2.0/13.3.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@toruslabs%2ffetch-node-details/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@toruslabs%2ffetch-node-details/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@toruslabs%2ffetch-node-details/13.2.0/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@toruslabs%2ffetch-node-details/13.2.0/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>torusresearch/fetch-node-details (@​toruslabs/fetch-node-details)</summary> ### [`v13.3.0`](https://togithub.com/torusresearch/fetch-node-details/releases/tag/v13.3.0) [Compare Source](https://togithub.com/torusresearch/fetch-node-details/compare/v13.2.0...v13.3.0) #### What's Changed - fix: errors are not being sent to Sentry by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/76](https://togithub.com/torusresearch/fetch-node-details/pull/76) - Pd 3414/update deps by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/74](https://togithub.com/torusresearch/fetch-node-details/pull/74) - Pd 3414/fix sentry no errors 2 by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/78](https://togithub.com/torusresearch/fetch-node-details/pull/78) - redact sentry data by [@​chaitanyapotti](https://togithub.com/chaitanyapotti) in [https://github.com/torusresearch/fetch-node-details/pull/79](https://togithub.com/torusresearch/fetch-node-details/pull/79) - chore: update http-helpers and loglevel-sentry by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/80](https://togithub.com/torusresearch/fetch-node-details/pull/80) - feat: introduce `Trace-Id` header by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/81](https://togithub.com/torusresearch/fetch-node-details/pull/81) - Pd 3415/sentry sample rate configurable by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/82](https://togithub.com/torusresearch/fetch-node-details/pull/82) - added support for tss-frost endpoints by [@​himanshuchawla009](https://togithub.com/himanshuchawla009) in [https://github.com/torusresearch/fetch-node-details/pull/83](https://togithub.com/torusresearch/fetch-node-details/pull/83) #### New Contributors - [@​maneki-admin](https://togithub.com/maneki-admin) made their first contribution in [https://github.com/torusresearch/fetch-node-details/pull/76](https://togithub.com/torusresearch/fetch-node-details/pull/76) **Full Changelog**: torusresearch/fetch-node-details@v13.2.0...v13.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
shottah
referenced
this pull request
in zed-io/kolektivo
May 15, 2024
…valora-inc#5305) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@toruslabs/fetch-node-details](https://togithub.com/torusresearch/fetch-node-details-sapphire#readme) ([source](https://togithub.com/torusresearch/fetch-node-details)) | [`^13.2.0` -> `^13.3.0`](https://renovatebot.com/diffs/npm/@toruslabs%2ffetch-node-details/13.2.0/13.3.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@toruslabs%2ffetch-node-details/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@toruslabs%2ffetch-node-details/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@toruslabs%2ffetch-node-details/13.2.0/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@toruslabs%2ffetch-node-details/13.2.0/13.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>torusresearch/fetch-node-details (@​toruslabs/fetch-node-details)</summary> ### [`v13.3.0`](https://togithub.com/torusresearch/fetch-node-details/releases/tag/v13.3.0) [Compare Source](https://togithub.com/torusresearch/fetch-node-details/compare/v13.2.0...v13.3.0) #### What's Changed - fix: errors are not being sent to Sentry by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/76](https://togithub.com/torusresearch/fetch-node-details/pull/76) - Pd 3414/update deps by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/74](https://togithub.com/torusresearch/fetch-node-details/pull/74) - Pd 3414/fix sentry no errors 2 by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/78](https://togithub.com/torusresearch/fetch-node-details/pull/78) - redact sentry data by [@​chaitanyapotti](https://togithub.com/chaitanyapotti) in [https://github.com/torusresearch/fetch-node-details/pull/79](https://togithub.com/torusresearch/fetch-node-details/pull/79) - chore: update http-helpers and loglevel-sentry by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/80](https://togithub.com/torusresearch/fetch-node-details/pull/80) - feat: introduce `Trace-Id` header by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/81](https://togithub.com/torusresearch/fetch-node-details/pull/81) - Pd 3415/sentry sample rate configurable by [@​maneki-admin](https://togithub.com/maneki-admin) in [https://github.com/torusresearch/fetch-node-details/pull/82](https://togithub.com/torusresearch/fetch-node-details/pull/82) - added support for tss-frost endpoints by [@​himanshuchawla009](https://togithub.com/himanshuchawla009) in [https://github.com/torusresearch/fetch-node-details/pull/83](https://togithub.com/torusresearch/fetch-node-details/pull/83) #### New Contributors - [@​maneki-admin](https://togithub.com/maneki-admin) made their first contribution in [https://github.com/torusresearch/fetch-node-details/pull/76](https://togithub.com/torusresearch/fetch-node-details/pull/76) **Full Changelog**: torusresearch/fetch-node-details@v13.2.0...v13.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://toruslabs.atlassian.net/browse/PD-3415
Currently, all errors are not being sent to Sentry. This will make sure all errors will be captured by Sentry. Will dial down later if needed