Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pd 4084 update typescript test #45

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

hieu-w
Copy link
Contributor

@hieu-w hieu-w commented Nov 6, 2024

Motivation and Context

Jira Link: https://toruslabs.atlassian.net/browse/PD-4084

Description

  • Convert JS tests -> Typescript tests
  • Use Vitest
  • Remove Karma + mocha
  • Update command

How has this been tested?

Run npm run test:all
CI runner on GitHub Action

Screenshots (if appropriate):

Screenshot 2024-11-07 at 01 21 39

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@hieu-w hieu-w marked this pull request as ready for review November 6, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant