Fix stalling in Pipeline command #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astaric
force-pushed
the
pipeline-stalling
branch
from
0a691ba
to
713edca
Compare
When a command (other than the first) in a pipeline wrote more than 64k to the stderr, and the output was consumed with the iter_lines function, the whole pipeline stalled. Fixed by reading the output of all commands where either stdout or stderr was set to PIPE.
somehow stderr includes an empty line when run on pypy
astaric
force-pushed
the
pipeline-stalling
branch
from
3c2f649
to
57a1dea
Compare
henryiii
reviewed
Nov 1, 2023
|
@henryiii do you plan to release new version soon? Stalling pipelines is something we've bumped in several times, this fix seems important. I don't know how new releases are made, but if there is anything I can help with, I am ready :) |
|
Yeah, I'm planning one pretty soon. I want to get a release out then drop Python 3.6. |
|
Hi @henryiii ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a command (other than the first) in a pipeline wrote more than 64k to the stderr, and the output was consumed with the iter_lines function, the whole pipeline stalled. Fixed by reading the output of all commands where either stdout or stderr was set to PIPE.
This is the same issue as described in
#548
Same problem still exists if command is executed with run(), but that code calls proc.communicate to read stderr/stdout and I do not know how to fix that.