Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate port mapping and show image sizes #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reinstate port mapping and show image sizes #3

wants to merge 1 commit into from

Conversation

teyc
Copy link

@teyc teyc commented Mar 18, 2016

No description provided.

todthomson
todthomson reviewed Mar 18, 2016
View reviewed changes
Step5.md
COPY . /app/
WORKDIR /app/approot
EXPOSE 5000/tcp
ENTRYPOINT ["./web", "--server.urls", "http://0.0.0.0:5000"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teyc does this make the port binding work below? if so 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. To connect to it you'll need the IP address of the docker instance.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teyc I'll take another look at this once I have landed the "chapter 5" changes from @hgaard as he's completely rewriting chapter 5 and is adding a new "docker deep dive" chapter 6a/6b. We'll make sure it works like the above once we do that.

@todthomson
Copy link
Owner

I'll test this out tomorrow thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teyc @todthomson