-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise escape-timeout from 0 to 1 #60
base: master
Are you sure you want to change the base?
Conversation
…hen loading several components in the .bashrc file on Windows Subsystem for Linux 2.
I support this for a plugin that's intended to be a "sensible" set of defaults that noone can object to. No human being will ever perceive a delay of 1 ms, and it patches Issue #61 for WSL users. |
This makes sense, let's merge it |
Not sure if this repository is maintained but this change did fix similar issues for me in WSL2. (Very) difficult problem to diagnose, so it definitely seems like this patch would be useful to have and prevent future headaches. It's also worth noting that the SuperUser answer that is cited in this setting's comment in the plugin explicitly discourages doing what the plugin is doing (although, that seems to be an edit more recent than this PR, so):
For more rationale as to why this configuration setting is a poor idea [and definitely does not fit the stated purpose of this repository], see the referenced answer here: https://superuser.com/a/1809494 Not sure if any additional information is required to merge this PR as it has been sitting untouched for over two years. |
As of tmux 3.4 (which is not released yet), tmux will actually stop you from setting this value to 0. |
It's a sensible default value, as stated by various sources:
Even if tmux 3.4 fixes this by hardcoding a change from 0 to 1, the previous versions should still be able to benefit from this plugin without experiencing breaking behaviour. |
The description of escape-time in README.md still says 0. This PR should probably include a change to that as well. |
The version of tmux installed with |
Raise escape-timeout from 0 to 1 to avoid catching Bash color codes when loading several components in the .bashrc file on Windows Subsystem for Linux 2.