Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT-3324: Update dependencies and move tinymce to be an optional peer dependency #395

Merged
merged 8 commits into from
Jul 24, 2024
Merged

INT-3324: Update dependencies and move tinymce to be an optional peer dependency #395

merged 8 commits into from
Jul 24, 2024

Conversation

danoaky-tiny
Copy link
Contributor

@danoaky-tiny danoaky-tiny commented Jul 24, 2024 •
edited
Loading

INT-3324

Changes:

  • The tinymce package is now an optional peer dependency and a dev dependency. The dev dependency has been updated to v7, which is used internally for types. Both of these are breaking changes.
  • Imports of tinymce now use import type ... to help prevent accidental usage of tinymce JS code through a direct import in this way.
  • Upgraded other dependencies to latest.
  • Added a type check before using old editor mode API. This is now needed because of the tinymce dev dep update.

@danoaky-tiny danoaky-tiny requested a review from a team as a code owner July 24, 2024 02:01
kemister85
kemister85 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥂

  • yarn
  • yarn build
  • yarn lint
  • yarn storybook

@danoaky-tiny danoaky-tiny merged commit 57120be into main Jul 24, 2024
5 checks passed
@danoaky-tiny danoaky-tiny deleted the feature/INT-3324 branch July 24, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSpyder TheSpyder TheSpyder approved these changes

@MitchC1999 MitchC1999 MitchC1999 approved these changes

@kemister85 kemister85 kemister85 approved these changes

@shanmen-tiny shanmen-tiny shanmen-tiny approved these changes

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers

@hamza0867 hamza0867 Awaiting requested review from hamza0867 hamza0867 is a code owner automatically assigned from tinymce/tinymce-reviewers

@jscasca jscasca Awaiting requested review from jscasca

@ArvinJ-H ArvinJ-H Awaiting requested review from ArvinJ-H

@ltrouton ltrouton Awaiting requested review from ltrouton

@FarzadHayat FarzadHayat Awaiting requested review from FarzadHayat

@tiny-ben-tran tiny-ben-tran Awaiting requested review from tiny-ben-tran

@Skylite73 Skylite73 Awaiting requested review from Skylite73

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danoaky-tiny @TheSpyder @MitchC1999 @kemister85 @shanmen-tiny