Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-3298: Updated tests to BDD style #390

Merged
merged 23 commits into from
Jul 8, 2024
Merged

INT-3298: Updated tests to BDD style #390

merged 23 commits into from
Jul 8, 2024

Conversation

danoaky-tiny
Copy link
Contributor

@danoaky-tiny danoaky-tiny commented Jun 14, 2024

Ticket: INT-3298

Changes:

  • Replaced agar style chain/step tests with usage of describe, context & it.
  • Added TestHooks.ts which contains BDD hooks for creating generic component fixtures and TinyMCE editor specific fixtures. As well as a convenience function for running tests in version contexts: eachVersionContext.
  • Added TestHelpers.ts for other misc/alien helper or utils.
  • Added teardown: { destroyAfterEach: true } to the TestBed.InitTestEnvironment call, which simplifies fixture disposal.
  • Removed TestStore.ts as it's no longer needed/used.
  • Added an eslint override for *Test.ts & /test//*.ts files.
  • Added more tests for reactive forms and on push change detection mode to FormControlTest.ts

@danoaky-tiny danoaky-tiny requested a review from a team as a code owner June 14, 2024 07:12
* INT-3299: Check that an existing element with an id does not equal the current elementRef

* INT-3299: Added captureLogs function

* INT-3299: Added chai package for testing as well allowing it in eslint

* INT-3299: Added PropTest.ts

* INT-3299: Removed a comment

* INT-3299: Increased timeout

* INT-3299: use a `pTryUntil` instead of `waitForEditorsToLoad`
@danoaky-tiny danoaky-tiny merged commit cbd092a into main Jul 8, 2024
3 checks passed
@danoaky-tiny danoaky-tiny deleted the feature/INT-3298 branch July 8, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants