-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT-3298: Updated tests to BDD style #390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nent, removing the need for editorHookStandalone
Also removed TestStore.ts as it's no longer needed.
danoaky-tiny
requested review from
spocke,
TheSpyder,
hamza0867,
jscasca,
ArvinJ-H,
ltrouton,
MitchC1999,
shanmen-tiny and
tiny-ben-tran
and removed request for
a team
June 14, 2024 07:12
MitchC1999
approved these changes
Jun 20, 2024
ltrouton
approved these changes
Jul 8, 2024
* INT-3299: Check that an existing element with an id does not equal the current elementRef * INT-3299: Added captureLogs function * INT-3299: Added chai package for testing as well allowing it in eslint * INT-3299: Added PropTest.ts * INT-3299: Removed a comment * INT-3299: Increased timeout * INT-3299: use a `pTryUntil` instead of `waitForEditorsToLoad`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: INT-3298
Changes:
describe
,context
&it
.TestHooks.ts
which contains BDD hooks for creating generic component fixtures and TinyMCE editor specific fixtures. As well as a convenience function for running tests in version contexts:eachVersionContext
.TestHelpers.ts
for other misc/alien helper or utils.teardown: { destroyAfterEach: true }
to theTestBed.InitTestEnvironment
call, which simplifies fixture disposal.TestStore.ts
as it's no longer needed/used.FormControlTest.ts