Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cursor jumping at the beginning #371

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

davidediak
Copy link

@davidediak davidediak requested a review from a team as a code owner February 7, 2024 13:36
@davidediak davidediak requested review from spocke, TheSpyder and ltrouton and removed request for a team February 7, 2024 13:36
Copy link
Contributor

@danoaky-tiny danoaky-tiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have a test for this in FormControlTest.ts. Thanks for the fix!

@davidediak
Copy link
Author

Sure, I fixed your tests and also added a test related to my fix.
Please feel free to contribute to the tests if needed, I'm not really familiar with your internal testing lib.

@danoaky-tiny
Copy link
Contributor

Ah thank you. #367 also has a fix for this failing test. Once that's merged I'll rereview

@constanzaccg
Copy link

Hi! Is there any plan to incorporate this fix soon? Thank you

@danoaky-tiny
Copy link
Contributor

@davidediak This needs a merge from main. Just to do with the tests, won't need much change from you.

@davidediak
Copy link
Author

@danoaky-tiny sure, done.

@EkimChau
Copy link

EkimChau commented May 8, 2024

Hello davidediak,

Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this can be done through the Tiny Contributor License Agreement (Tiny CLA). Please contact [email protected] to sign the Tiny CLA agreement.

@davidediak
Copy link
Author

@EkimChau you have my permission to use my code, given the fact that I spent time fixing the bug and did open a PR.
I have no intention of proving your company with my personal data.

@TheSpyder
Copy link
Member

This is clearly stated in the contributing guide. We don't have an automated system for it at the moment.

Note that contributions will require signing of our Contributor License Agreement.

The CLA protects us, our open-source community and our customers from the distribution of unauthorised code. It's non-negotiable, sorry.

@davidediak
Copy link
Author

Btw guys, you can copy-paste my changes and open another PR, I won't mind.
I won't give away any personal data, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants