-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cursor jumping at the beginning #371
base: main
Are you sure you want to change the base?
fix: cursor jumping at the beginning #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to have a test for this in FormControlTest.ts
. Thanks for the fix!
Sure, I fixed your tests and also added a test related to my fix. |
Ah thank you. #367 also has a fix for this failing test. Once that's merged I'll rereview |
Hi! Is there any plan to incorporate this fix soon? Thank you |
@davidediak This needs a merge from main. Just to do with the tests, won't need much change from you. |
@danoaky-tiny sure, done. |
Hello davidediak, Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this can be done through the Tiny Contributor License Agreement (Tiny CLA). Please contact [email protected] to sign the Tiny CLA agreement. |
@EkimChau you have my permission to use my code, given the fact that I spent time fixing the bug and did open a PR. |
This is clearly stated in the contributing guide. We don't have an automated system for it at the moment. tinymce-angular/CONTRIBUTING.md Line 8 in 5bcfde8
The CLA protects us, our open-source community and our customers from the distribution of unauthorised code. It's non-negotiable, sorry. |
Btw guys, you can copy-paste my changes and open another PR, I won't mind. |
#321