Add OSIE files and location customization: #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
force-pushed
the
osie-location
branch
from
3e7709e
to
049c450
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
===================================
- Coverage 52% 52% -1%
===================================
Files 26 26
Lines 2139 2157 +18
===================================
+ Hits 1126 1133 +7
- Misses 977 985 +8
- Partials 36 39 +3 ☔ View full report in Codecov by Sentry. |
This plumbs through the spec.interfaces[].netboot.osie from the v1alpha1 API into Smee for customization of the auto.ipxe script. This allow Hardware objects to customize the OSIE file and location. Currently, only a global CLI flag was available. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
It was safecast parsing the wrong value. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
osie-location
branch
from
b0aac9c
to
206ef93
Compare
Signed-off-by: Jacob Weinstock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This plumbs through the
spec.interfaces[].netboot.osiefrom the v1alpha1 API into Smee for customization of the auto.ipxe script. This allow Hardware objects to customize the OSIE file and location. Currently,only a global CLI flag was available.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: