Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom path for grub.cfg #144

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ttwd80
Copy link

@ttwd80 ttwd80 commented Sep 2, 2024

Description

Add the ability to specify custom location for grub.cfg.

Why is this needed

Ubuntu 24.04 cloud image mounts the /boot partition. The default /boot/grub/grub.cfg location is invalid when we mount the partition. The location when there is a /boot partition is grub/grub.cfg.

Fixes: #142

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

It uses the default value of boot/grub/grub.cfg for GRUBCFG_PATH if not specified. Existing users are not impacted.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

More info on Ubuntu 24.04 cloud image partition - https://bugs.launchpad.net/cloud-images/+bug/2072929

Signed-off-by: Titi Wangsa bin Damhore <[email protected]>
Signed-off-by: Titi Wangsa bin Damhore <[email protected]>
@ttwd80 ttwd80 marked this pull request as ready for review September 2, 2024 17:45
Signed-off-by: Titi Wangsa bin Damhore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action kexec hardcodes grub.cfg location
1 participant