Skip to content
This repository has been archived by the owner on Aug 27, 2021. It is now read-only.

Test refactoring #3

Merged
merged 62 commits into from
Mar 31, 2021
Merged

Test refactoring #3

merged 62 commits into from
Mar 31, 2021

Conversation

KeisukeShima
Copy link
Collaborator

@KeisukeShima KeisukeShima commented Mar 2, 2021

What kinds of PR

  • New feature
  • Improve feature
  • Bug fix

What is this PR

class ObstacleStopPlannerNode

Key input: pathCallback(input/trajectory)

Class diagram

class_diagram_orig

Proposal class diagram
class_diagram_refine-1

How to check this PR

@KeisukeShima KeisukeShima self-assigned this Mar 2, 2021
@KeisukeShima KeisukeShima force-pushed the test-refactoring branch 2 times, most recently from bb123aa to 0427dff Compare March 17, 2021 10:55
@KeisukeShima KeisukeShima marked this pull request as ready for review March 17, 2021 10:58
@KeisukeShima KeisukeShima marked this pull request as draft March 17, 2021 11:08
@KeisukeShima KeisukeShima marked this pull request as ready for review March 18, 2021 07:08
@codecov-io
Copy link

codecov-io commented Mar 18, 2021

Codecov Report

Merging #3 (20f124b) into main (374003d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main      #3   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          5      11    +6     
  Lines       1141    1092   -49     
=====================================
+ Misses      1141    1092   -49     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ine/include/obstacle_stop_planner/debug_marker.hpp 0.00% <ø> (ø)
...ude/obstacle_stop_planner/obstacle_point_cloud.hpp 0.00% <0.00%> (ø)
...include/obstacle_stop_planner/one_step_polygon.hpp 0.00% <0.00%> (ø)
...nner_refine/include/obstacle_stop_planner/util.hpp 0.00% <0.00%> (ø)
...cle_stop_planner/util/create_vehicle_footprint.hpp 0.00% <0.00%> (ø)
...top_planner_refine/src/adaptive_cruise_control.cpp 0.00% <0.00%> (ø)
obstacle_stop_planner_refine/src/debug_marker.cpp 0.00% <0.00%> (ø)
obstacle_stop_planner_refine/src/node.cpp 0.00% <0.00%> (ø)
..._stop_planner_refine/src/obstacle_stop_planner.cpp 0.00% <0.00%> (ø)
obstacle_stop_planner_refine/src/point_helper.cpp 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374003d...20f124b. Read the comment docs.

@kmiya
Copy link
Contributor

kmiya commented Mar 18, 2021

@KeisukeShima Clang-Tidy result is here. Could you please check the warnings and kindly fix the code? tidy-result.txt

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KeisukeShima Could you show me the metrics change calculated by lizard?

@KeisukeShima
Copy link
Collaborator Author

@kmiya I modified source code to pass clang-tidy. I ignored some warnings because it seems wrong.

@KeisukeShima
Copy link
Collaborator Author

@kenji-miyake You can see metrics report here: https://tier4.github.io/obstacle_stop_planner_refine/pr-check/3-code-metrics.html

@kenji-miyake
Copy link
Contributor

@KeisukeShima I can confirm there are many improvements from the viewpoint of code metrics!

  • Reduced CCN, LOC
  • Reduced number of functions
  • Parameters has increased, so should be reduced

Let's continue to improve more!

Left: Before(https://tier4.github.io/obstacle_stop_planner_refine/pr-check/main-code-metrics.html)
Right: After(https://tier4.github.io/obstacle_stop_planner_refine/pr-check/3-code-metrics.html)

image

@KeisukeShima KeisukeShima mentioned this pull request Mar 29, 2021
3 tasks
@kenji-miyake kenji-miyake merged commit a7cad4b into main Mar 31, 2021
@kenji-miyake kenji-miyake deleted the test-refactoring branch March 31, 2021 04:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants