Skip to content

Commit

Permalink
helm: fix graceful shutdown for reana-server
Browse files Browse the repository at this point in the history
Avoid using `/bin/sh -c` to run uwsgi, as that breaks signal
propagation.

Closes reanahub/reana-job-controller#347
  • Loading branch information
mdonadoni committed Sep 26, 2023
1 parent e240f3e commit 9dd672d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Version 0.9.1 (UNRELEASED)
- Fixes uWSGI memory consumption on systems with very high allowed number of open files.
- Fixes cronjob failures due to database connection issues when REANA is deployed with non-default namespace or prefix.
- Fixes ``ingress.enabled`` option to correctly enable or disable the creation of Ingresses.
- Fixes graceful shutdown for reana-server and reana-workflow-controller.
- Adds new configuration options ``login`` and ``secrets.login`` for configuring Keycloak SSO login with third-party authentication services.
- Developers:
- Fixes ``cluster-deploy``, ``cluster-undeploy`` and ``client-setup-environment`` commands when using custom instance name or kubernetes namespace.
Expand Down
4 changes: 2 additions & 2 deletions helm/reana/templates/reana-server.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ spec:
tty: true
stdin: true
{{- else }}
command: ["/bin/sh", "-c"]
args: ["uwsgi --ini /var/reana/uwsgi/uwsgi.ini"]
# do not use "/bin/sh -c" here as that breaks signal propagation
command: ["uwsgi", "--ini", "/var/reana/uwsgi/uwsgi.ini"]
{{- end }}
volumeMounts:
{{- if .Values.debug.enabled }}
Expand Down

0 comments on commit 9dd672d

Please sign in to comment.