Fix the directory pathname while moving directories

[AzukiPaste]

Fix the duplicate directory name error that occurs when the destination directory already exists while moving folders.

[tiann]

Under what circumstances would a user create a vendor/product file in the module root directory? If a user creates it unknowingly and the file gets overwritten, the issue would still exist.

[AzukiPaste]

I have noticed the WARNING DO NOT MANUALLY CREATE OR MODIFY.
However, install_module creates vendor/product/system_ext files in MODPATH during installation if any user uses variable REMOVE or REPLACE.
Currently the lines of # Handle remove files are superior of handle_partition lines in installer.sh, so here comes the bug: modified files in MODPATH/system/system_ext which are supposed to overlay would be moved to MODPATH/system_ext/system_ext then the overlay path wrongs too.

[AzukiPaste]

If files realpath is in /vendor or /product or /system_ext partitions, its okay when REMOVE="$(readlink -f "$file" | sed 's|^/vendor/|/system&|;s|^/product/|/system&|;s|^/system_ext/|/system&|')".

Maybe changing the using method of REMOVE is a proper way to fix the situation mentioned above.

Look forward for your reply.

[tiann]

I think I understand what you mean by:

If the user wants to REMOVE /vendor/priv-app/A, and /system/vendor is a symlink to /vendor; if it writes:

REMOVE=/vendor/priv-app/A is normal, but if it uses

REMOVE=/system/vendor/priv-app/A will result in wrong path; is it so?

[AzukiPaste]

Sorry I did not clearly comment. Let me try describing more.

If the user wants to REMOVE /vendor/priv-app/A, and /system/vendor is a symlink to /vendor; and MODULE ZIP FILE contains /system/vendor/priv-app/B to REPLACE /vendor/priv-app/B;
if he writes:

REMOVE=/vendor/priv-app/A
- /vendor/priv-app/A will be REMOVEd normally;
- /vendor/priv-app/B will NOT be REPLACEd. $MODZIP/system/vendor/priv-app/B will be in /vendor/vendor/priv-app/B.
- At this case, $MODPATH/vendor created by REMOVE exists, then mv $MODPATHE/system/vendor $MODPATH/vendor will result in wrong path.

REMOVE=/system/vendor/priv-app/A
- /vendor/priv-app/A will be REMOVEd normally;
- /vendor/priv-app/B will be PEPLACEd normally.
- At this case, files moved from $MODPATH/system/vendor to $MODPATH/vendor without problem(existance of destination directory) and everything works well.

[tiann]

Thank you, i understand it.

[tiann]

I'll revert this since it causes other bugs:

1. REPLACE=/system/product/app/A would fail, because there isn't any file in directory, only dir, so find "$1" -type f would find nothing.
2. REMOVE=/system/product/app/A would fail, because find "$1" -type f would skip character devices.