Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: speedup bank payment query #637

Merged

Conversation

SunnyCloudYang
Copy link
Contributor

🎉 Thanks for taking time to contribute! 🎉

What is the purpose of this PR?

  • Improve performance

  • I understand that adding a new feature before creating a feature request issue has a high chance of rejection.

Please describe your changes.

parallelize bank payment requests

@UNIDY2002
Copy link
Member

将请求打散并行化的方式可能不适合应用在这里,因为银行代发系统支持的并行度有限,这样做未必能降低延迟。

顺便,像课程表按每三周切片查询其实也不是为了降低延迟,而是 18 周一起查数据量太大,可能导致返回空结果。

@SunnyCloudYang
Copy link
Contributor Author

将请求打散并行化的方式可能不适合应用在这里,因为银行代发系统支持的并行度有限,这样做未必能降低延迟。

顺便,像课程表按每三周切片查询其实也不是为了降低延迟,而是 18 周一起查数据量太大,可能导致返回空结果。

emmm那分成少一点的几组会有用吗?比如6组?现在查一次十几秒确实有点难蚌(当然主要还是信息中心那边太不给力了😓

@UNIDY2002
Copy link
Member

是不是用户并不需要每次都看全量数据,如果是这样的话,我觉得可以让用户自己选择查询的时间范围,或者直接采用和官方网站一样的交互?

@SunnyCloudYang
Copy link
Contributor Author

要不默认显示最近三个月,可以点击加载更多之后每次向前查询三个月?

@UNIDY2002
Copy link
Member

听起来合理

@84634E1A607A
Copy link
Contributor

84634E1A607A commented Oct 29, 2024

我倾向于一开始加载3个月, 按钮直接叫加载全部 (x

我个人认为有查大于3个月之前的代发需求的同学可能会想看完整个代发 (x

@SunnyCloudYang SunnyCloudYang marked this pull request as ready for review October 30, 2024 12:48
@UNIDY2002 UNIDY2002 merged commit 94d0a3c into thu-info-community:master Oct 30, 2024
2 checks passed
@SunnyCloudYang SunnyCloudYang deleted the bank_payment_boost branch October 30, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants