fix: fix some ui stuff in settings page (#644)

* fix: fix some ui stuff in settings page * fix: fix details * feat: adjust
thu-info-community · Oct 31, 2024 · daea785 · daea785
1 parent 94d0a3c
commit daea785
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/apps/thu-info-app/src/ui/settings/feedback.tsx b/apps/thu-info-app/src/ui/settings/feedback.tsx
@@ -161,7 +161,7 @@ export const FeedbackScreen = ({navigation}: {navigation: RootNav}) => {
 							marginVertical: 8,
 							marginEnd: 8,
 							paddingHorizontal: 12,
-							paddingVertical: Platform.OS === "android" ? 7 : 12,
+							paddingVertical: 12 - 1, // minus border width
 							backgroundColor: colors.themeBackground,
 							color: colors.text,
 							borderColor: colors.inputBorder,

diff --git a/apps/thu-info-app/src/ui/settings/functionManagement.tsx b/apps/thu-info-app/src/ui/settings/functionManagement.tsx
@@ -99,7 +99,7 @@ export const FunctionManagementScreen = () => {
 				<Text style={{marginLeft: 8, color: colors.fontB2, marginTop: 12}}>
 					{getStr(name)}
 				</Text>
-				<RoundedView style={[style.rounded, {marginTop: 12}]}>
+				<RoundedView style={[style.rounded, {marginTop: 8}]}>
 					{functions[name].map((f, index) => (
 						<FunctionItem
 							key={f}
@@ -121,7 +121,7 @@ export const FunctionManagementScreen = () => {
 			{Object.keys(functions).map((name) =>
 				FunctionGroup(name as functionGroups),
 			)}
-			<View style={{marginBottom: 16}} />
+			<View style={{height: 32}} />
 		</ScrollView>
 	);
 };
diff --git a/apps/thu-info-app/src/ui/settings/privacy.tsx b/apps/thu-info-app/src/ui/settings/privacy.tsx
@@ -35,6 +35,7 @@ export const PrivacyScreen = () => {
 				style={{
 					backgroundColor: theme.colors.themeBackground,
 					flex: 1,
+					padding: 12,
 				}}>
 				<WebView
 					source={{

diff --git a/apps/thu-info-app/src/ui/settings/settings.tsx b/apps/thu-info-app/src/ui/settings/settings.tsx
@@ -9,6 +9,7 @@ import {
 	useColorScheme,
 	View,
 	ScrollView,
+	StyleSheet,
 } from "react-native";
 import Snackbar from "react-native-snackbar";
 import {setDormPassword} from "../../redux/slices/credentials";
@@ -227,8 +228,8 @@ export const styles = themedStyles(({colors}) => ({
 		fontSize: 16,
 	},
 	separator: {
-		borderWidth: 0.4,
-		borderColor: colors.themeGrey,
+		borderBottomWidth: StyleSheet.hairlineWidth,
+		borderBottomColor: colors.themeGrey,
 		marginVertical: 12,
 		marginHorizontal: 16,
 	},