always close http response body

threefoldtech · Mar 20, 2020 · 66248f2 · 66248f2
1 parent 3da7f23
commit 66248f2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/pkg/capacity/store.go b/pkg/capacity/store.go
@@ -76,6 +76,8 @@ func (s *HTTPStore) Register(nodeID pkg.Identifier, c Capacity, d dmi.DMI, disks
 	if err != nil {
 		return err
 	}
+	defer resp.Body.Close()
+
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("wrong response status code received: %v", resp.Status)
 	}
@@ -100,6 +102,8 @@ func (s *HTTPStore) Ping(nodeID pkg.Identifier, uptime uint64) error {
 	if err != nil {
 		return err
 	}
+	defer resp.Body.Close()
+
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("wrong response status code received: %v", resp.Status)
 	}

diff --git a/pkg/flist/flist.go b/pkg/flist/flist.go
@@ -349,6 +349,7 @@ func (f *flistModule) downloadFlist(url string) (string, error) {
 	if err != nil {
 		return "", err
 	}
+	defer resp.Body.Close()
 
 	if resp.StatusCode != 200 {
 		return "", fmt.Errorf("fail to download flist: %v", resp.Status)

diff --git a/pkg/identity/store.go b/pkg/identity/store.go
@@ -60,6 +60,8 @@ func (s *httpIDStore) RegisterNode(node pkg.Identifier, farm pkg.FarmID, version
 	if err != nil {
 		return "", err
 	}
+	defer resp.Body.Close()
+
 	if resp.StatusCode != http.StatusCreated {
 		return "", fmt.Errorf("wrong response status code received: %v", resp.Status)
 	}

diff --git a/pkg/upgrade/hub.go b/pkg/upgrade/hub.go
@@ -61,6 +61,7 @@ func (h *hubClient) Info(flist string) (info flistInfo, err error) {
 	if response.StatusCode != http.StatusOK {
 		return info, fmt.Errorf("failed to get flist info: %s", response.Status)
 	}
+	defer response.Body.Close()
 
 	dec := json.NewDecoder(response.Body)