Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use bundler-cache, and rely on on ruby/setup-ruby to have patch versions of Ruby #1467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

olleolleolle
Copy link
Contributor

This PR uses the bundler-cache feature of the Ruby-maintained Action ruby/setup-ruby.

See ruby/setup-ruby parameters declaration for more information.

@olleolleolle
Copy link
Contributor Author

olleolleolle commented Dec 3, 2021

About quoting "3.0":

This is a very small change, but which avoids a Float-to-String loss of characters.

An example (not from this project) of what it can look like before this change, in this picture:

bild

Read more details, if you like: actions/runner#849

@olleolleolle olleolleolle changed the title CI: Use bundler-cache CI: Use bundler-cache, and rely on on ruby/setup-ruby to have patch versions of Ruby Dec 3, 2021
@olleolleolle
Copy link
Contributor Author

If this PR is merged, it also does what #1466 did (in another way).

@vsppedro
Copy link
Collaborator

vsppedro commented Dec 4, 2021

Thank you for working on this!

I tried to use the ruby/setup-ruby, but it did not work as you can see in this PR: #1397.

If you like to understand why the CI is failing take a look at this comment: #1397 (comment)

I intended to test these options: #1397 (comment), but I forgot. 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants