Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to require full namespace #1669

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnpitchko
Copy link
Contributor

FactoryBot throws an error when defining factories that refer to classes within modules in non-Rails applications. FactoryBot will work, but the class used by the factory must be explicitly stated in the full namespace.

Address #1459

@johnpitchko
Copy link
Contributor Author

Hey not sure why this is failing. Am I able to resubmit the failing test?

@sarahraqueld
Copy link
Contributor

Hey not sure why this is failing. Am I able to resubmit the failing test?

The tests are failing on main currently, this is not related to your changes. We're working on fixing it on another PR. And thanks for your submission, I hope we can review and approve soon!

@johnpitchko
Copy link
Contributor Author

Hey not sure why this is failing. Am I able to resubmit the failing test?

The tests are failing on main currently, this is not related to your changes. We're working on fixing it on another PR. And thanks for your submission, I hope we can review and approve soon!

Thank you Sarah. Looks like all the tests are passing now 👍 .

@johnpitchko
Copy link
Contributor Author

Hi @sarahraqueld I noticed this is still open. Can we re-execute the checks? I don't believe I can on my end.

@smaboshe
Copy link
Contributor

Thank you, @johnpitchko. Could you rebase against main? That should trigger CI to re-run.

FactoryBot throws an error when defining factories that refer to classes
within modules in non-Rails applications. FactoryBot will work, but the
class used by the factory must be explicitly stated in the full
namespace.
@johnpitchko johnpitchko force-pushed the update-docs-for-specifying-namespace branch from fbf0c92 to 6ea3d55 Compare September 21, 2024 05:58
@johnpitchko
Copy link
Contributor Author

Thank you @smaboshe I rebased as you said, but it seems that the Ruby 3.0 / Rails 6.1 build task is stuck in a loop of Resolving dependencies....

@smaboshe
Copy link
Contributor

Thanks for the rebase. Not sure why that particular build task is failing. We'll take a look.

@johnpitchko
Copy link
Contributor Author

Hello, I noticed this is still failing and I'm unable to retrigger the build. Can someone investigate or re-trigger please? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants