Accumulated build files since #2411 #2673
Conversation
|
I think it might be necessary to add the |
|
Hm, the intent is that we'd update How much of a problem is this creating when developing between releases? |
|
By updating modules with Dependabot, running |
|
Ah yeah, that'd do it. This feels like something we can automate in CI so that we catch it when working on the PR. I'll give that some thought. |
In #2673, we discussed catching changes in the `builds` directory as being quite annoying in development. This can happen when people contribute changes (and should probably also commit their build changes to make future development easier), plus also when dependencies change. Catching this with `diff-check` should mean that we see this at the point of introduction, rather than later on.
|
I opened #2680 to try something out for this, and it was easier than I thought. I wondered if I'd need to make some modifications to |
|
Another issue with not checking in the assets is that gems included from Git (eg: |
Not sure what to make of this one. I was getting these build files in a branch I was working on. Eventually I realised this was happening in main too. Seems to be the case since merging #2411, and I think changes might have been accumulating over time?
So... should these be committed then?
I can't add @littleforest as a reviewer for some reason, so pinging here instead.