Make output target display not have local targets hanging around so much #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split out from another PR I'm working on, to try to keep that one a bit more sane.
What I'm observing is that while I have local build actions running at a fair pace, with remote execution online but being underutilised, the display shows a lot more local actions than I'd expect. It isn't actually executing them, just showing their 'shadow' for a few seconds.
This happens because the display is using a common set of 'slots' for them which is shared between both. This changes it so each has its own set of 'available slots' that are not shared. The eventual result is that you see a few local actions at the top of the list, to a max of the number of local workers that are configured, with all the remote ones beneath them.
This is what was intended all along but it wasn't quite doing it; I don't think we have anywhere where we'd really observe it right now, you'd need something like remote execution enabled with a whole bunch of actions with
local = Trueon them (we have no such actions internally, it's been a requirement that everything supports remote execution for a few years now).