Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'default' entry in provide map for when there's no match #3138

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Tatskaari
Copy link
Member

@Tatskaari Tatskaari commented Apr 24, 2024

With #3140 this should allow us to default to no dependency when the require can't be satisfied, which would be nice in a number of circumstances.

Comment on lines 567 to 568
// TODO(jpoole): shouldn't this use the ProvideFor wrapper that handles resolving to self if there's no match?
labels := t.provideFor(target, ffDefaultProvide)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably requires a bit of thought

Copy link
Member

@peterebden peterebden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. The plumbing for the feature flag is slightly awkward but I think it's the right thing to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants