Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hiding deprecated config options #2853

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

peterebden
Copy link
Member

This marks all the language-specific stuff as deprecated and adds a feature flag that stops asp from getting them on its config object.

Hopefully this will start cutting down on errors from these (e.g. #2851 ran across another one that we never updated and which had been silently using the wrong Go tool for months); we should find out immediately that these don't exist.

@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had any recent activity in the past 90 days. It will be closed if no further activity occurs. If you require additional support, please reply to this message. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 15, 2023
@peterebden peterebden added the not-stale Ensures that this issue isn't auto-closed due to inactivity label Oct 16, 2023
@peterebden
Copy link
Member Author

Hush, bot.

I'm not sure what the immediate future is here - the main issue is that I'm not sure how to update the C++ plugin to work in the new world as it did before. We need to figure that out anyway though.
Maybe I should also try to split out some of the noncontroversial bits from here (although to me their existence argues for the utility of this feature, so I would like to get it sorted sometime).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-stale Ensures that this issue isn't auto-closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant