Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to download original image #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iclysdale
Copy link

For what I'm using it for, it's important for folks to be able to download originals while browsing, not just downloading the whole directory, so I hacked it in. It might be useful to others, so I figured I'd pitch it for the whole package.

@thibaud-rohmer
Copy link
Owner

Eh.... it's already there : you have the "get" button when you display an
image that does that. No ?

On 29 June 2012 19:50, iclysdale <
[email protected]

wrote:

For what I'm using it for, it's important for folks to be able to download
originals while browsing, not just downloading the whole directory, so I
hacked it in. It might be useful to others, so I figured I'd pitch it for
the whole package.

You can merge this Pull Request by running:

git pull https://github.com/iclysdale/PhotoShow master

Or you can view, comment on it, or merge it online at:

#164

-- Commit Summary --

  • Add option to download original photo

-- File Changes --

M src/classes/CurrentUser.php (1)
M src/classes/ImageBar.php (3)
M src/classes/Index.php (2)
M src/classes/Provider.php (4)

-- Patch Links --

https://github.com/thibaud-rohmer/PhotoShow/pull/164.patch
https://github.com/thibaud-rohmer/PhotoShow/pull/164.diff


Reply to this email directly or view it on GitHub:
#164

@iclysdale
Copy link
Author

No. It may be meant to (in which case I can merge and fix), but get returns the medium sized generated image, rather than the full-sized original. Calling imagejpeg on line 277 in Provider.class seems to return that - by adding the check to not do that if Original was set to true, it returned the full size version.

@CyberShadow
Copy link
Contributor

I think the "Get" button should just download the original file, not a downscaled version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants