Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance AppData file #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enhance AppData file #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 27 additions & 13 deletions share/metainfo/gpick.appdata.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,7 @@
naming of colors, and a scheme generator.
</p>
</description>
<screenshots>
<screenshot type="default">
<image>http://static.gpick.org/image/appdata-screenshot-0.2.6.png</image>
<caption>The main window showing the application in action</caption>
</screenshot>
</screenshots>
<url type="homepage">http://www.gpick.org</url>
<url type="bugtracker">https://github.com/thezbyg/gpick</url>
<update_contact>[email protected]</update_contact>
<developer_name>Albertas Vyšniauskas</developer_name>
<url type="donation">http://www.gpick.org/help/donation.html</url>
<url type="help">http://www.gpick.org/help.html</url>
<translation type="gettext">gpick</translation>
<launchable type="desktop-id">gpick.desktop</launchable>
<keywords>
<keyword>color</keyword>
<keyword>picker</keyword>
Expand All @@ -37,5 +25,31 @@
<keyword>palette</keyword>
<keyword>scheme</keyword>
</keywords>
<kudos>
<kudo>ModernToolkit</kudo>
<kudo>HiDpiIcon</kudo>
<kudo>HighContrast</kudo>
</kudos>
<screenshots>
<screenshot type="default">
<caption>The main window showing the application in action</caption>
<image>http://static.gpick.org/image/appdata-screenshot-0.2.6.png</image>
</screenshot>
</screenshots>
<developer_name>Albertas Vyšniauskas</developer_name>
<url type="bugtracker">https://github.com/thezbyg/gpick</url>
<url type="donation">http://www.gpick.org/help/donation.html</url>
<url type="help">http://www.gpick.org/help.html</url>
<url type="homepage">http://www.gpick.org</url>
<url type="translate">http://www.gpick.org/help/translation.html</url>
<translation type="gettext">gpick</translation>
<content_rating type="oars-1.0" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be oars-1.1 in order to have it as an empty XML tag.

Copy link
Author

@scx scx Dec 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source?
I used the oars generator by hughsie.
The appstream-util considers this to be correct and many applications on Flathub use exactly the same empty tag:
https://github.com/flathub/com.bitwarden.desktop/blob/16ecfae90dffb072ca5d2ea3900cb34bf0a8c961/com.bitwarden.desktop.appdata.xml#L53
https://github.com/flathub/com.calibre_ebook.calibre/blob/b3bfed61a7ea49df185945ae3a5daa171baa9460/com.calibre_ebook.calibre.appdata.xml#L28
https://github.com/flathub/net.sourceforge.Teo/blob/ad6ea0dcf7e36eec1965388e357f4935cc4307a3/teo-7722f5749d52537b24808cd621a519f3d05b1e1a....patch#L6992
https://github.com/flathub/org.eclipse.iot.fourdiac.Ide/blob/df836bd8b481504f7c023fdf84ee2a3fa49ebce2/4diac-ide.appdata.xml#L22
https://github.com/flathub/space.fips.Fips/blob/30038cb77d9f258b5bc0f044b0986ab93f6f7cdb/space.fips.Fips.appdata.xml#L4

Even nedrichards confirmed that this is correct and he is Flathub maintainer.
flathub/flathub#525 (comment)
Anyway, if you think it's incorrect, you should report it to hugsie.

<update_contact>[email protected]</update_contact>
<provides>
<binary>gpick</binary>
</provides>
<releases>
<release version="0.2.6~rc" date="2017-09-07"/>
<release version="0.2.5" date="2013-02-28"/>
</releases>
</component>