Remove path prefix only if $path contains prefix #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 And if I understand https://tools.ietf.org/html/rfc4918#section-8.3 correct relative urls are allowed. Would be nice to have a test case for it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am testing a webdav implementation with Nginx on Debian 10. I have encountered an error trying to list the contents of a directory. The problem is that in the
listContentsfunction it removes as many characters as the prefix of the path, even if the path returned by the webdav server does not contain the prefix. This causes the necessary part of the returned file paths to be removed.In my case the following happened:
Prefix:
http://192.168.0.103:20000/Route returned by webdav:
/uploads/user/8546/2020-06-12Result:
06-12