switch to .eslint.yml, change config to use latest eslint and correct… #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… eslint wp plugin, update imagemin-mozjpeg to v8+, composer update
|
❤️ ESLint, but can we avoid updating other packages in this PR? |
|
Why? Imagemin had a security issue if I remember correctly, what so bad in using 8.0 and browser sync was just a few minor versions within the set constrains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… eslint wp plugin, update imagemin-mozjpeg to v8+ (had a security issue I think), composer update.
I think its cool to use
latestfor eslint and the wp config..eslintrcis deprecated, I like YAML 100 times more then JSON. If you want to keep JSON you need to have.jsonending.