Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Began adding an R-native writer. #48

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Began adding an R-native writer. #48

wants to merge 3 commits into from

Conversation

LTLA
Copy link
Contributor

@LTLA LTLA commented Apr 28, 2021

Pretty much as it says. Missing all the sparse bits and pieces for obsp, varp and the sparse layers; this is waiting on grimbough/rhdf5#80. Will need some testing, as usual; I haven't verified that it works with Python, but it does at least work with the R-native reader. (One nice property of the zellkonverter set-up is that we can easily check one implementation against the other.)

Wait for #46 to resolve before we even consider merging this bad boy.

@ivirshup
Copy link
Member

ivirshup commented May 13, 2021

Just a heads up on this, I will be making some changes to the on disk format of AnnData for the next release. Most of these changes will just be adding metadata to written elements so we are never inferring how to read them back in. This metadata will include a name of the type and a version for the encoding. See scverse/anndata#554 for details.

In short, maybe hold off on merging this until that's through? These changes should be landing on the development branch on AnnData before the end of June.

@LTLA
Copy link
Contributor Author

LTLA commented May 13, 2021

I'm down for that. We're close to the next BioC release and I'd like to spend what time we have left on checking the reader.

@ivirshup ivirshup mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants