Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puppet 8 support #884

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add Puppet 8 support #884

merged 1 commit into from
Nov 13, 2023

Conversation

bastelfreak
Copy link
Member

also contains #883

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires #888

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our upgrade test requires versions to be set:

case ENV['BEAKER_PUPPET_COLLECTION']
when 'puppet7'
from_version = '7.6.0'
to_version = '7.13.0'
else
raise 'Unsupported Puppet collection'
end

We pick the oldest and newest versions that are available for all the platforms.

@ekohl
Copy link
Member

ekohl commented Nov 13, 2023

I took the liberty of adding to your PR, hopefully to move things forward.

@ekohl ekohl merged commit db073e3 into theforeman:master Nov 13, 2023
19 checks passed
@bastelfreak bastelfreak deleted the puppet8 branch November 13, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants