Cleanup configuration file #340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Aug 23, 2021
| @@ -135,7 +134,7 @@ def modules | |||
| end | |||
|
|
|||
| def module(name) | |||
| modules.find { |m| m.name == name } | |||
| modules.find { |m| m.identifier == name } | |||
There was a problem hiding this comment.
This looks like a bugfix. Could you provide a bit more info about why it's wrong?
There was a problem hiding this comment.
I tried to update the commit message with more information. The most telling is to look at the hook context documentation. Unfortunately, I think name in some areas of code refers to the Puppet naming scheme with :: and in other places it references this internal "name" construct that Kafo creates -- https://github.com/theforeman/kafo/blob/master/lib/kafo/puppet_module.rb#L175
The previous implementation relied on the name of the module to be specified which is a specially constructured replacement of colons with underscores. The hook context calls on this method and indicates using the identifier as a typicaly Puppet user would encounter it. For example, my_example::foo would be specified rather than a user thinking to convert this to my_example_foo. Thus this worked for single level classes, this would have failed for multilevel classes.
ehelms
force-pushed
the
cleanup-configuration-file
branch
from
c85e949
to
6defecf
Compare
|
@ekohl Could you revisit a review on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.