Rename --verbose-log-level to --terminal-log-level #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name
--verbose-log-levelis ambiguous. The user could interpret this to mean that they are making logs more verbose, rather than terminal output, and may not realize it does nothing if they don't also pass--verbose true.This PR aims to make this easier to understand by renaming it to
--terminal-log-levelto indicate it refers to the log level of terminal output. (--stdout-log-levelmay be a better name... I am open to suggestions).The old
--verbose-log-leveloption still exists and still functions, but it no longer has a default and now also prints a deprecation notice to stderr.