Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PULL_REQUEST_TEMPLATE.md for improved contribution guidelines #741

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

nofaralfasi
Copy link
Contributor

No description provided.

@ares
Copy link
Member

ares commented Sep 27, 2024

I like the template, seeing it in action in Katello repository proofs its usefulness. I'd just consider, whether you want to have the checkbox always there. For someone who contributes regularly, it may become annoying to always confirm they read the contributing guildelines.

@nofaralfasi nofaralfasi merged commit 0bd8029 into theforeman:master Oct 7, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants